Skip to content

Display a notification when using JediLSP with Python 2.7 - #17407

Merged
Kim-Adeline Miguel (kimadeline) merged 37 commits into
microsoft:mainfrom
kimadeline:11995-27-notification
Sep 14, 2021
Merged

Display a notification when using JediLSP with Python 2.7#17407
Kim-Adeline Miguel (kimadeline) merged 37 commits into
microsoft:mainfrom
kimadeline:11995-27-notification

Conversation

@kimadeline

@kimadeline Kim-Adeline Miguel (kimadeline) commented Sep 13, 2021

Copy link
Copy Markdown

For #17512

image

Using a diagnostic as discussed in the previous PR.

Deleting all Jedi-related stuff will be in a separate PR ♻️

@karrtikr Kartik Raj (karrtikr) left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise

Comment thread src/client/application/diagnostics/checks/jediPython27NotSupported.ts Outdated
Comment thread src/client/activation/activationService.ts Outdated
Comment thread src/client/activation/activationService.ts Outdated
Comment thread src/client/application/diagnostics/checks/jediPython27NotSupported.ts Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog No news entry required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants